From f54e4b60ccb2c2ad4ebb5fdee48fe45d24af3a88 Mon Sep 17 00:00:00 2001 From: Kit Langton Date: Wed, 25 Mar 2026 20:19:58 -0400 Subject: [PATCH] file: use Effect.cached for scan deduplication (#19164) --- packages/opencode/src/file/index.ts | 24 ++++++++---------------- 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/packages/opencode/src/file/index.ts b/packages/opencode/src/file/index.ts index 86f7bb0dce..61f1af89d3 100644 --- a/packages/opencode/src/file/index.ts +++ b/packages/opencode/src/file/index.ts @@ -2,7 +2,7 @@ import { BusEvent } from "@/bus/bus-event" import { InstanceState } from "@/effect/instance-state" import { makeRuntime } from "@/effect/run-service" import { Git } from "@/git" -import { Effect, Fiber, Layer, Scope, ServiceMap } from "effect" +import { Effect, Layer, ServiceMap } from "effect" import { formatPatch, structuredPatch } from "diff" import fs from "fs" import fuzzysort from "fuzzysort" @@ -323,7 +323,6 @@ export namespace File { interface State { cache: Entry - fiber: Fiber.Fiber | undefined } export interface Interface { @@ -348,7 +347,6 @@ export namespace File { Effect.fn("File.state")(() => Effect.succeed({ cache: { files: [], dirs: [] } as Entry, - fiber: undefined as Fiber.Fiber | undefined, }), ), ) @@ -406,21 +404,15 @@ export namespace File { s.cache = next }) - const scope = yield* Scope.Scope + let cachedScan = yield* Effect.cached( + scan().pipe(Effect.catchCause(() => Effect.void)), + ) const ensure = Effect.fn("File.ensure")(function* () { - const s = yield* InstanceState.get(state) - if (!s.fiber) - s.fiber = yield* scan().pipe( - Effect.catchCause(() => Effect.void), - Effect.ensuring( - Effect.sync(() => { - s.fiber = undefined - }), - ), - Effect.forkIn(scope), - ) - yield* Fiber.join(s.fiber) + yield* cachedScan + cachedScan = yield* Effect.cached( + scan().pipe(Effect.catchCause(() => Effect.void)), + ) }) const init = Effect.fn("File.init")(function* () {